Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qdl: update to the latest upstream #599

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

ricardosalveti
Copy link
Contributor

@ricardosalveti ricardosalveti commented May 28, 2024

Update to the latest upstream repository, which is now at
https://github.com/linux-msm/qdl.git.

Relevant changes from latest upstream:

  • USBDEVFS interface replaced with libusb
  • Add ramdump support
  • New utility 'ks' which uses sahara to load images from host to a
    device (relevant for Qualcomm Cloud AI 100).

Drop 0001-Makefile-Use-pkg-config-for-libxml2-detection.patch as these
changes are now available upstream.

Copy link
Collaborator

@lumag lumag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fails for me:

ERROR: qdl-0.0+b18bca7d285a3ade92b6ec94b5d41fa149658314-r0 do_package_qa: QA Issue: File /usr/bin/ks in package qdl doesn't have GNU_HASH (didn't pass LDFLAGS?)
File /usr/bin/qdl in package qdl doesn't have GNU_HASH (didn't pass LDFLAGS?)
File /usr/bin/qdl-ramdump in package qdl doesn't have GNU_HASH (didn't pass LDFLAGS?) [ldflags]
ERROR: qdl-0.0+b18bca7d285a3ade92b6ec94b5d41fa149658314-r0 do_package_qa: Fatal QA errors were found, failing task.
ERROR: Logfile of failure stored in: /home/lumag/Projects/RPB/build-rpb/tmp-rpb-glibc/work/armv8a-linaro-linux/qdl/0.0+b18bca7d285a3ade92b6ec94b5d41fa149658314/temp/log.do_package_qa.3081535

@lumag
Copy link
Collaborator

lumag commented May 28, 2024

Also there is no need to list upstream changelog in the commit message. Please drop it. Instead provide a rationality, why the package needs to be upgraded.

@ricardosalveti
Copy link
Contributor Author

Fails for me:

ERROR: qdl-0.0+b18bca7d285a3ade92b6ec94b5d41fa149658314-r0 do_package_qa: QA Issue: File /usr/bin/ks in package qdl doesn't have GNU_HASH (didn't pass LDFLAGS?)
File /usr/bin/qdl in package qdl doesn't have GNU_HASH (didn't pass LDFLAGS?)
File /usr/bin/qdl-ramdump in package qdl doesn't have GNU_HASH (didn't pass LDFLAGS?) [ldflags]
ERROR: qdl-0.0+b18bca7d285a3ade92b6ec94b5d41fa149658314-r0 do_package_qa: Fatal QA errors were found, failing task.
ERROR: Logfile of failure stored in: /home/lumag/Projects/RPB/build-rpb/tmp-rpb-glibc/work/armv8a-linaro-linux/qdl/0.0+b18bca7d285a3ade92b6ec94b5d41fa149658314/temp/log.do_package_qa.3081535

Didn't fail for me, but could be my settings / environment, will test on a basic / clean setup.

@ricardosalveti
Copy link
Contributor Author

Also there is no need to list upstream changelog in the commit message. Please drop it. Instead provide a rationality, why the package needs to be upgraded.

Sure, this is a common practice on other layers, which is why I added, but will remove.

@ricardosalveti
Copy link
Contributor Author

CI failures not related to this change.

@ricardosalveti
Copy link
Contributor Author

Fails for me:

ERROR: qdl-0.0+b18bca7d285a3ade92b6ec94b5d41fa149658314-r0 do_package_qa: QA Issue: File /usr/bin/ks in package qdl doesn't have GNU_HASH (didn't pass LDFLAGS?)
File /usr/bin/qdl in package qdl doesn't have GNU_HASH (didn't pass LDFLAGS?)
File /usr/bin/qdl-ramdump in package qdl doesn't have GNU_HASH (didn't pass LDFLAGS?) [ldflags]
ERROR: qdl-0.0+b18bca7d285a3ade92b6ec94b5d41fa149658314-r0 do_package_qa: Fatal QA errors were found, failing task.
ERROR: Logfile of failure stored in: /home/lumag/Projects/RPB/build-rpb/tmp-rpb-glibc/work/armv8a-linaro-linux/qdl/0.0+b18bca7d285a3ade92b6ec94b5d41fa149658314/temp/log.do_package_qa.3081535

Didn't fail for me, but could be my settings / environment, will test on a basic / clean setup.

I think I see what caused this, patch I dropped (which needs to be removed) changed ldflags to append instead of a force set. Will send this upstream first and get back to this.

Update to the latest upstream repository, which is now at
https://github.com/linux-msm/qdl.git.

Relevant changes from latest upstream:
- USBDEVFS interface replaced with libusb
- Add ramdump support
- New utility 'ks' which uses sahara to load images from host to a
  device (relevant for Qualcomm Cloud AI 100).

Drop 0001-Makefile-Use-pkg-config-for-libxml2-detection.patch as these
changes are now available upstream.

Signed-off-by: Ricardo Salveti <[email protected]>
@ricardosalveti
Copy link
Contributor Author

Updated and removed the local patch since it is not required anymore (after cflags/ldflags issue was merged upstream: linux-msm/qdl#63).

@lumag lumag merged commit 568a9f5 into Linaro:master May 28, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants